Skip to content

[ci]: Add path based PR labeling - #2281

Open
hickeyma wants to merge 3 commits into
llm-d:mainfrom
hickeyma:ci-add-labeler-workflow
Open

[ci]: Add path based PR labeling#2281
hickeyma wants to merge 3 commits into
llm-d:mainfrom
hickeyma:ci-add-labeler-workflow

Conversation

@hickeyma

@hickeyma hickeyma commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

What type of PR is this?
/kind feature

What this PR does / why we need it:
All ten area/* labels now exist in the repo. This wires up the remaining eight (area/scheduling, area/flowcontrol, area/kvcache, area/coordinator, area/sidecar, area/datalayer, area/telemetry, area/docs) via actions/labeler, alongside area/epp and area/dev. .github/labeler.yml is now the single source of truth for the path globs. docs/area_taxonomy.md drops its table and keeps only the /area directive explanation and the additive overlap rule.

/cc @elevran

Which issue(s) this PR fixes:
Partial #956 (Phase 4, Labeling)

Release note (write NONE if no user-facing change):

NONE

Copilot AI lite review requested due to automatic review settings August 5, 2026 13:28
@hickeyma
hickeyma requested a review from a team as a code owner August 5, 2026 13:28
@hickeyma
hickeyma requested review from ahg-g and elevran August 5, 2026 13:28
@github-actions github-actions Bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. kind/feature Categorizes issue or PR as related to a new feature. labels Aug 5, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR introduces automated, path-based labeling for the existing area/epp and area/dev labels using actions/labeler, and updates the area taxonomy documentation to reflect .github/labeler.yml as the canonical source for those two labels’ path globs (while keeping the remaining areas documented until their labels are created).

Changes:

  • Add a new pull_request_target workflow to apply area labels based on changed file paths.
  • Add .github/labeler.yml defining path globs for area/epp and area/dev.
  • Update docs/area_taxonomy.md to remove the area/epp/area/dev table rows and document the new source-of-truth location.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
docs/area_taxonomy.md Updates the taxonomy to point area/epp/area/dev to .github/labeler.yml and keeps the other (not-yet-created) area labels in the docs table.
.github/workflows/pr-area-labeler.yaml Adds a PR workflow that runs actions/labeler to apply path-based area labels.
.github/labeler.yml Defines the path globs for area/epp and area/dev used by the labeler workflow.

Comment thread .github/workflows/pr-area-labeler.yaml Outdated

@elevran elevran left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do you want me to create all relevant labels and then amend the PR to reflect that?
Instead of doing it in two PR steps.
Let me know all missing labels (kind, area, etc) and I'll add them.

Or can merge as is.
WDYT?

@hickeyma

hickeyma commented Aug 5, 2026

Copy link
Copy Markdown
Contributor Author

do you want me to create all relevant labels and then amend the PR to reflect that?

If you can create the labels that would be great, thanks @elevran. Use the table doc in the PR as its the latest. Let me know when its done and I'll update this PR then.

@hickeyma

hickeyma commented Aug 5, 2026

Copy link
Copy Markdown
Contributor Author

Setting PR to draft for now waiting on labels and updates required afterwards.

@hickeyma
hickeyma marked this pull request as draft August 5, 2026 16:13
@hickeyma hickeyma changed the title [ci]: Add path based area/epp and area/dev PR labeling [wip][ci]: Add path based area/epp and area/dev PR labeling Aug 5, 2026
@github-actions github-actions Bot added kind/feature Categorizes issue or PR as related to a new feature. and removed kind/feature Categorizes issue or PR as related to a new feature. labels Aug 5, 2026
@elevran

elevran commented Aug 5, 2026

Copy link
Copy Markdown
Collaborator

@hickeyma all area labels created

@elevran

elevran commented Aug 5, 2026

Copy link
Copy Markdown
Collaborator
image

@elevran elevran self-assigned this Aug 6, 2026
area/epp and area/dev currently exist as labels in the repo. The other areas
are defined in docs/area_taxonomy.md for now. Wire up the two that exist
via actions/labeler which also becomes the source of truth for
their path globs instead of the docs table. The other eight stay in
the table until their labels get created (llm-d#956).

Signed-off-by: Martin Hickey <martin.hickey@ie.ibm.com>
@hickeyma
hickeyma force-pushed the ci-add-labeler-workflow branch from 6768789 to b006332 Compare August 13, 2026 20:11
All ten area/* labels now exist in the repo, so the remaining eight
(scheduling, flowcontrol, kvcache, coordinator, sidecar, datalayer,
telemetry, docs) can move from the docs/area_taxonomy.md table into
.github/labeler.yml alongside area/epp and area/dev. labeler.yml is
now the single source of truth for the path globs. The doc keeps
only the /area directive and the additive-overlap rule.

Signed-off-by: Martin Hickey <martin.hickey@ie.ibm.com>
@github-actions github-actions Bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 13, 2026
@hickeyma hickeyma changed the title [wip][ci]: Add path based area/epp and area/dev PR labeling [ci]: Add path based area/epp and area/dev PR labeling Aug 13, 2026
@hickeyma
hickeyma marked this pull request as ready for review August 13, 2026 20:45
@github-actions github-actions Bot added kind/feature Categorizes issue or PR as related to a new feature. and removed kind/feature Categorizes issue or PR as related to a new feature. labels Aug 13, 2026
@hickeyma hickeyma changed the title [ci]: Add path based area/epp and area/dev PR labeling [ci]: Add path based PR labeling Aug 13, 2026
@github-actions github-actions Bot added kind/feature Categorizes issue or PR as related to a new feature. and removed kind/feature Categorizes issue or PR as related to a new feature. labels Aug 13, 2026
@hickeyma

Copy link
Copy Markdown
Contributor Author

Thanks @elevran for creating the labels. Added in commit 98ab57e.

@github-actions github-actions Bot added kind/feature Categorizes issue or PR as related to a new feature. and removed kind/feature Categorizes issue or PR as related to a new feature. labels Aug 13, 2026
@hickeyma
hickeyma requested a review from elevran August 13, 2026 20:52
@github-actions github-actions Bot added kind/feature Categorizes issue or PR as related to a new feature. and removed kind/feature Categorizes issue or PR as related to a new feature. labels Aug 13, 2026
The job only adds labels (sync-labels: false), unlike pr-kind-label.yaml
remove then add sequence, so nothing a canceled run can leave in a bad state.

Co-Pilot review:
- llm-d#2281 (comment)

Signed-off-by: Martin Hickey <martin.hickey@ie.ibm.com>

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated no new comments.

Suppressed comments (1)

docs/area_taxonomy.md:12

  • The manual-labeling bullet has a broken inline-code path (leading space and missing .github/ prefix), and both bullets are missing trailing periods, which makes the docs harder to follow and the referenced path incorrect.
- Manually: add an `/area <name>` line to a PR or issue body (see ` github/workflows/pr-kind-label.yaml` and `.github/workflows/issue-kind-label.yaml`)
- Automatically: `.github/labeler.yml` applies the matching `area/*` label(s) on every PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind/feature Categorizes issue or PR as related to a new feature. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants