Skip to content

fix: correct mamory typo and add false positives to _typos.toml (#161) - #166

Open
aditya226-sharma wants to merge 1 commit into
llm-d-incubation:mainfrom
aditya226-sharma:fix/typos
Open

fix: correct mamory typo and add false positives to _typos.toml (#161)#166
aditya226-sharma wants to merge 1 commit into
llm-d-incubation:mainfrom
aditya226-sharma:fix/typos

Conversation

@aditya226-sharma

@aditya226-sharma aditya226-sharma commented Aug 19, 2026

Copy link
Copy Markdown

Summary

Fixes the one real typo detected by the nightly scan and adds false positives for variable names.

Changes

  • Fixed mamory -> memory in third_party/gpu-cr/src/GPUs/AMD/amd.h:20
  • Added _typos.toml with false positives for vas (virtual addresses) and eit (iterator name)

Note

The vas and eit matches are variable names, not typos. The nightly scanner flagged them incorrectly.

Closes #161

Summary by CodeRabbit

  • Documentation
    • Corrected an inaccurate comment describing AMD GPU memory management.
  • Chores
    • Updated spelling validation to recognize additional accepted terms.

@coderabbitai

coderabbitai Bot commented Aug 19, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: a7b37dfd-70f3-44ae-bbed-3f777a4e4fc0

📥 Commits

Reviewing files that changed from the base of the PR and between e1b2aab and 6cfbb2a.

📒 Files selected for processing (2)
  • _typos.toml
  • third_party/gpu-cr/src/GPUs/AMD/amd.h

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.


📝 Walkthrough

Walkthrough

The change updates typo-checker exceptions for vas and eit, and corrects mamory to memory in an AMD memory-management comment.

Changes

Typo Corrections

Layer / File(s) Summary
Typo validation and comment cleanup
_typos.toml, third_party/gpu-cr/src/GPUs/AMD/amd.h
The typo configuration preserves vas and eit as accepted words. The AMD comment corrects “mamory” to “memory”.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: ⚪ Minimal · up to 6cfbb

This PR makes a localized typo correction and updates typo-scanner exceptions; no actionable merge-blocking risk remains beyond normal checks and review.

Suggested reviewers: aishukamal

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly summarizes the typo correction and false-positive configuration changes.
Linked Issues check ✅ Passed The changes correct mamory and allow vas and eit as false positives, meeting issue #161 objectives.
Out of Scope Changes check ✅ Passed All changes directly support the typo corrections and false-positive configuration required by issue #161.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

Copy link
Copy Markdown

Unsigned commits detected! Please sign your commits.

For instructions on how to set up GPG/SSH signing and verify your commits, please see GitHub Documentation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Typos detected by nightly scan (10 found)

2 participants