Skip to content

Enable adding labels in schema - #202

Merged
Gregory-Pereira merged 3 commits into
llm-d-incubation:mainfrom
Gregory-Pereira:enable-adding-labels-in-schema
Jan 31, 2026
Merged

Enable adding labels in schema#202
Gregory-Pereira merged 3 commits into
llm-d-incubation:mainfrom
Gregory-Pereira:enable-adding-labels-in-schema

Conversation

@Gregory-Pereira

Copy link
Copy Markdown
Contributor

Core feature: Enable specifying other labels in the values schema

Cleanup:

  • app version should match minor version
  • rename labels to reflect normal k8s labels, ex:
llm-d.ai/inferenceServing: "true" --> llm-d.ai/inference-serving: "true"
llm-d.ai/model: random-model
  • remove random-model as a default label

Signed-off-by: greg pereira <grpereir@redhat.com>
Signed-off-by: greg pereira <grpereir@redhat.com>
Signed-off-by: greg pereira <grpereir@redhat.com>
@Gregory-Pereira

Copy link
Copy Markdown
Contributor Author

FYI @kalantar, im going to proceed with this to pull into the guides for some QOL updates. I don't expect any objections because its just default labels but if so let me know in post and we can discuss / revert if needed

@Gregory-Pereira
Gregory-Pereira merged commit 3d7ce67 into llm-d-incubation:main Jan 31, 2026
5 checks passed
@zdtsw

zdtsw commented Feb 2, 2026

Copy link
Copy Markdown
Contributor

will this be a problem for existing resources? e.g the label is immutable on deployment. the new one inference-serving will be added but the old one infereneServing remains on deployment, then the pod selector wont be able to find pod with inference-serving instead of inferenceServing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants