Skip to content

add student (name or email) in chat page - #1113

Merged
mmoehabb merged 2 commits into
masterfrom
devmo/sub-name-by-email-page-v2
Oct 26, 2025
Merged

add student (name or email) in chat page#1113
mmoehabb merged 2 commits into
masterfrom
devmo/sub-name-by-email-page-v2

Conversation

@DevMuhammed3

Copy link
Copy Markdown
Collaborator

Summary

@DevMuhammed3
DevMuhammed3 requested a review from mmoehabb October 21, 2025 14:51
@DevMuhammed3 DevMuhammed3 self-assigned this Oct 21, 2025
Comment on lines +97 to +98
const displayName =
otherMember?.name || getEmailUserName(otherMember?.email || "");

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You cannot declare mere variables/constants within react components.

@DevMuhammed3
DevMuhammed3 force-pushed the devmo/sub-name-by-email-page-v2 branch from 27a92bb to 2767a42 Compare October 23, 2025 13:44
@DevMuhammed3
DevMuhammed3 requested a review from mmoehabb October 23, 2025 13:51
@mmoehabb
mmoehabb force-pushed the devmo/sub-name-by-email-page-v2 branch from 2767a42 to 14288ab Compare October 26, 2025 11:14
@mmoehabb
mmoehabb merged commit 53012da into master Oct 26, 2025
3 checks passed
@mmoehabb
mmoehabb deleted the devmo/sub-name-by-email-page-v2 branch October 26, 2025 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants