feat(web): add navbar timer. - #1101
Open
moalidv wants to merge 1 commit into
Open
Conversation
moalidv
force-pushed
the
mo/navbar-update
branch
2 times, most recently
from
October 20, 2025 18:26
dcc8aec to
c3affca
Compare
moalidv
marked this pull request as ready for review
October 20, 2025 18:32
moalidv
force-pushed
the
mo/navbar-update
branch
from
October 20, 2025 18:33
c3affca to
24a96fe
Compare
mmoehabb
requested changes
Oct 23, 2025
mmoehabb
left a comment
Collaborator
There was a problem hiding this comment.
- Subscribe now is not shown in the desktop screen.
- The bar doesn't look professional on relativily large phone screens, or tablets.
- The text should take all required space in large screens.
- Make the counter appears just like the design. There should be more space(s) between the digits.
- The timer is hidden for a couple seconds when the page starts loading (try to refresh the page while it's counting).
- The timer appears like this: "0 : NaN : NaN" when the session time is close.
moalidv
force-pushed
the
mo/navbar-update
branch
from
October 27, 2025 05:11
24a96fe to
667de6e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Render timer to the next lesson in alternative with subscribtion quote.
Navbar is removed from both chat page with active chat room and lesson page.
Cases that should be tested: