feat(chart): add topologySpreadConstraints#58
Open
bramwelt wants to merge 1 commit into
Open
Conversation
🤖 Generated with [Claude Code](https://claude.com/claude-code) Issue: LFXV2-1167 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> Signed-off-by: Trevor Bramwell <tbramwell@linuxfoundation.org>
There was a problem hiding this comment.
Pull request overview
This PR updates the Helm chart for lfx-v2-member-service to allow configuring Kubernetes topologySpreadConstraints via Helm values, enabling ArgoCD-provided values (per LFXV2-1167) to affect the rendered Deployment.
Changes:
- Add a conditional
topologySpreadConstraintsblock to the Deployment pod spec template. - Render the constraints using
toYamlwith proper indentation when the value is provided.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+22
to
+25
| {{- with .Values.topologySpreadConstraints }} | ||
| topologySpreadConstraints: | ||
| {{- toYaml . | nindent 8 }} | ||
| {{- end }} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
{{- with .Values.topologySpreadConstraints }}block todeployment.yamlso pods can be spread across nodes and availability zones via Helm valuesIssue: LFXV2-1167
🤖 Generated with Claude Code