-
Notifications
You must be signed in to change notification settings - Fork 1
[LFXV2-1476] feat(fga): add granular committee member access — roster_viewer and email_viewer #79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
andrest50
wants to merge
12
commits into
main
Choose a base branch
from
feat/LFXV2-1476-committee-fga-granular-scopes
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 8 commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
4695345
[LFXV2-1476] feat(fga): wire roster_viewer and email_viewer into comm…
andrest50 69227e2
[LFXV2-1476] feat(fga): add email_viewer gated contact endpoint and g…
andrest50 cbde4b2
[LFXV2-1476] fix(tests): update buildAccessControlMessage expectation…
andrest50 f18f825
Merge remote-tracking branch 'origin/main' into feat/LFXV2-1476-commi…
andrest50 b7c4069
[LFXV2-1476] fix(security): strip email from roster index and add con…
andrest50 7f0cfa0
[LFXV2-1476] feat(fga): add full_profile member_visibility with email…
andrest50 bd55ad4
test(committee): add explicit hidden visibility test case for buildAc…
andrest50 ae8db23
fix(committee): address PR review comments
andrest50 15a1a27
[LFXV2-1476] docs(indexer): update indexer contract and add email fie…
andrest50 debcdb9
[LFXV2-1476] fix(fga): make hidden member_visibility explicit in switch
andrest50 7bd0348
[LFXV2-1476] fix(review): address PR comment — populate top-level Tag…
andrest50 7862bec
[LFXV2-1476] feat(migrations): add split_member_index backfill script
andrest50 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CommitteeMemberBaseAttributes()is still used for update payloads and includesEmailAttribute()(and the update method requiresemail). Since the roster-view member endpoints no longer return email, clients that can update a member but don’t haveemail_viewermay have no way to obtain the current email to satisfy PUT “complete replacement” semantics. Consider makingemailoptional for updates (use stored email when omitted), switching to PATCH semantics for non-email updates, or explicitly ensuring the update permission impliesemail_viewerso callers can fetch/contactfirst.