Skip to content

[LFXV2-2690] feat(chart): use inviter relation for committee invite creation - #168

Merged
andrest50 merged 1 commit into
mainfrom
feat/LFXV2-2690-committee-inviter-ruleset
Aug 4, 2026
Merged

[LFXV2-2690] feat(chart): use inviter relation for committee invite creation#168
andrest50 merged 1 commit into
mainfrom
feat/LFXV2-2690-committee-inviter-ruleset

Conversation

@andrest50

@andrest50 andrest50 commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Update the Heimdall ruleset for POST /committees/:uid/invites to check the inviter relation instead of writer
  • The inviter relation (defined in the platform FGA model) covers members, auditors, and writers — allowing any committee member to send invites in invite-only join mode

Ticket

LFXV2-2690

🤖 Generated with Claude Code

Update the Heimdall ruleset for POST /committees/:uid/invites to check
the `inviter` relation instead of `writer`. The new `inviter` relation
(defined in the platform FGA model) covers members, auditors, and
writers, allowing any committee member to send invites in invite-only
join mode.

Closes LFXV2-2690

Generated with [Claude Code](https://claude.ai/code)

Signed-off-by: Andres Tobon <andrest2455@gmail.com>
Copilot AI balanced review requested due to automatic review settings August 4, 2026 18:08
@andrest50
andrest50 requested a review from a team as a code owner August 4, 2026 18:08
@coderabbitai

coderabbitai Bot commented Aug 4, 2026

Copy link
Copy Markdown

Review Change Stack

Walkthrough

The committee invite creation rule now requires the OpenFGA inviter relation instead of writer. Other routing, authentication, fallback authorization, and JWT finalization behavior is unchanged.

Changes

Committee invite authorization

Layer / File(s) Summary
Invite creation authorization rule
charts/lfx-v2-committee-service/templates/ruleset.yaml
The authorization check now requires the OpenFGA inviter relation instead of writer.

Estimated code review effort: 1 (Trivial) | ~2 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title clearly identifies the chart change and the switch to the inviter relation for committee invite creation.
Description check ✅ Passed The description accurately explains the ruleset change, affected endpoint, authorization scope, and deployment dependency.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feat/LFXV2-2690-committee-inviter-ruleset

Comment @coderabbitai help to get the list of available commands.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates invite creation authorization so committee members, auditors, and writers can send invitations via the companion OpenFGA inviter relation.

Changes:

  • Replaces the writer authorization check with inviter.
  • Retains authenticated OpenFGA authorization for the invite creation route.

@andrest50
andrest50 merged commit 4747b11 into main Aug 4, 2026
11 checks passed
@andrest50
andrest50 deleted the feat/LFXV2-2690-committee-inviter-ruleset branch August 4, 2026 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants