Skip to content

[WIP] Add permission check on committee Create Vote CTA click#998

Closed
Copilot wants to merge 1 commit into
feat/LFXV2-2252-committee-vote-permission-checkfrom
copilot/featvotes-add-permission-check
Closed

[WIP] Add permission check on committee Create Vote CTA click#998
Copilot wants to merge 1 commit into
feat/LFXV2-2252-committee-vote-permission-checkfrom
copilot/featvotes-add-permission-check

Conversation

Copilot AI commented Jun 20, 2026

Copy link
Copy Markdown
Contributor

Thanks for the feedback on #997. I've created this new PR, which merges into #997, to address your comment. I will work on the changes and keep this PR's description up to date as I make progress.

Original PR: #997
Triggering comment (#997 (comment)):

Review Feedback Addressed

Commit: 1b0e903

Changes Made

  • committee-votes.component.ts: Injected LensService; deny redirect now derives overviewPath from activeLens()/foundation/overview for the foundation lens, /project/overview otherwise. Matches writerGuard's lens-aware behavior exactly (per @copilot-pull-request-reviewer)

No Change Needed

  • CodeRabbit nitpick (loading guard for double-click prevention): Marked "💤 Low value / Optional" by CodeRabbit — navigation completes after the first successful/failed check, making a double-fire harmless in practice. Skipped.

Threads Resolved

1 of 1 unresolved threads addressed in this iteration.

Follow-up

committee-meetings.component.ts (onScheduleMeeting) has the same hard-coded /project/overview — shipped in #992. Will fix in a follow-up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants