build(docs): stop tracking generated search-index.json#995
Conversation
Signed-off-by: Fayaz G <5818912+fayazg@users.noreply.github.com>
There was a problem hiding this comment.
Copilot wasn't able to review any files in this pull request.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Important Review skippedReview was skipped as selected files did not have any reviewable changes. 💤 Files selected but had no reviewable changes (1)
⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
MRashad26
left a comment
There was a problem hiding this comment.
Review — PR #995 build/untrack-search-index
Verdict: PASS
Single-file housekeeping change. apps/lfx-one/public/assets/docs/search-index.json is a build artifact regenerated on every build by scripts/build-docs.mjs. It was accidentally force-committed in PR #825 alongside the .gitignore rule (/public/assets/docs) that was meant to exclude it. The ignore rule was already correct — the file just remained tracked, producing diff noise on every build.
This PR removes it from the index via git rm --cached (file kept on disk). Future builds regenerate it locally without it becoming a tracked change, consistent with the sibling artifacts (dist-docs/, src/app/modules/docs/generated/) which were already untracked.
Secrets check: Removed JSON is a MiniSearch index of public documentation pages only — no secrets or credentials.
Code standards: No Angular/TypeScript code changed — nothing to audit.
No issues found.
Summary
apps/lfx-one/public/assets/docs/search-index.jsonis a build artifact, regenerated on every build byscripts/build-docs.mjs(viadocs:build, chained intostart,build,build:*,watch, andtest, plus CI and Docker)..gitignore(/public/assets/docs, added in feat(docs): public-facing user documentation portal at /docs #825), but the file was force-committed in that same PR — so it stayed tracked and produced diff churn on every build.git rm --cached(file kept on disk); the ignore rule now takes effect, so builds no longer reintroduce tracked changes..gitignorechange needed — the rule was already present and correct. Sibling artifacts (dist-docs/,src/app/modules/docs/generated/) were already untracked; this bringssearch-index.jsonin line with them.