Skip to content

fix(chart): standardize tracesSamplerArg comment#102

Merged
dealako merged 1 commit into
mainfrom
fix/LFXV2-2568-otel-helm-config
Jul 2, 2026
Merged

fix(chart): standardize tracesSamplerArg comment#102
dealako merged 1 commit into
mainfrom
fix/LFXV2-2568-otel-helm-config

Conversation

@bramwelt

@bramwelt bramwelt commented Jul 2, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Standardizes the tracesSamplerArg Helm chart comment to match the canonical wording from lfx-v2-email-service
  • Expands single-line comment to the canonical 3-line form with (default: "") footer

Test plan

  • Comment in values.yaml matches canonical format

🤖 Generated with Claude Code

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Issue: LFXV2-2568
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Signed-off-by: Trevor Bramwell <tbramwell@linuxfoundation.org>
Copilot AI review requested due to automatic review settings July 2, 2026 23:07

@claude claude Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude Code Review

This repository is configured for manual code reviews. Comment @claude review to trigger a review and subscribe this PR to future pushes, or @claude review once for a one-time review.

Tip: disable this comment in your organization's Code Review settings.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR standardizes a single Helm chart comment. It expands the previous one-line description of the tracesSamplerArg OTEL value into the canonical three-line form used by lfx-v2-email-service, adding a (default: "") footer. I verified via code search that the new wording matches the canonical source (charts/lfx-v2-email-service/values.yaml) exactly. This is a documentation-only change with no functional impact.

Changes:

  • Replaces the single-line tracesSamplerArg comment with the canonical 3-line form.
  • Adds detail about which samplers use the argument and the (default: "") footer.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@dealako dealako merged commit 5845a53 into main Jul 2, 2026
8 checks passed
@dealako dealako deleted the fix/LFXV2-2568-otel-helm-config branch July 2, 2026 23:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants