This repository was archived by the owner on Jul 22, 2026. It is now read-only.
Pass WarmUpLoadBalancer constructor params in the correct order - #1147
Merged
Conversation
brycezhongqing
approved these changes
Feb 25, 2026
abhics1002
approved these changes
Feb 25, 2026
singhsanjay12
added a commit
that referenced
this pull request
Feb 26, 2026
Adds a @VisibleForTesting protected method `buildWarmUpLoadBalancer` to XdsLoadBalancerWithFacilitiesFactory and a regression test that verifies indisWarmUpTimeoutSeconds and indisWarmUpConcurrentRequests are passed in the correct order to the WarmUpLoadBalancer constructor (fixes #1147). Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was broken by #1124.