Decouple the block proposer from the authenticated owner#6590
Draft
ma2bd wants to merge 4 commits into
Draft
Conversation
…uthenticated owner
…' into ma2bd/decouple-proposer-from-owner # Conflicts: # linera-chain/src/data_types/mod.rs # linera-chain/src/manager.rs # linera-core/src/client/chain_client/mod.rs # linera-core/src/client/mod.rs
…' into ma2bd/decouple-proposer-from-owner # Conflicts: # linera-core/src/chain_worker/state.rs # linera-core/src/client/chain_client/mod.rs # linera-core/src/client/mod.rs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Stacked on #6589, which made the owner's signature over the whole block a first-class, self-verifying object carried in proposals and certificates. One restriction remains from before: a fresh proposal must be signed by the block's
authenticated_ownerthemselves. This conflates two roles — authorizing the block's operations (and fee liability) and participating in a consensus round — and forces the client to re-sign pending blocks as the owner that staged them, track whether it still holds that key, and hard-error on pending fast blocks whose key was lost.The block is the unit of authorization — a "transaction": the owner signs the entire proposed block, never operation subsets, so whoever carries that block to a round cannot alter what was authorized. Retries already work this way; this PR extends it to fresh proposals.
Proposal
authenticated_owner(if any) has signed the block — exactly the check Retain the block owner's proposal signature alongside certificates (#456) #6589 already performs. The super-owner requirement for authorizations claiming the fast round is unchanged.OwnerAuthorizationat staging time — when their key is by construction available — and it persists inPendingProposal. Pending blocks are then always proposed under the current identity: the "re-sign as the staged owner" logic and the key-availability dance are gone from the main path (a fallback remains for pending proposals from older wallets), and the previously unrecoverable pending-fast-block error becomes reachable only for legacy data.Test Plan
test_pending_block_discarded_when_signer_key_missingis inverted intotest_pending_block_proposed_by_other_owner_after_key_loss: the pending block staged by owneranow commits, proposed by ownerbaftera's key is withdrawn, and the resulting certificate retainsa's authorization, which verifies against the block.cargo test -p linera-chain -p linera-core -p linera-rpcpass; clippy clean including--all-features.Release Plan
devnetand release a new SDK soon.Links