Skip to content

closechannel: add functional options#224

Merged
guggero merged 2 commits into
lightninglabs:masterfrom
hieblmi:no-wait
May 26, 2025
Merged

closechannel: add functional options#224
guggero merged 2 commits into
lightninglabs:masterfrom
hieblmi:no-wait

Conversation

@hieblmi

@hieblmi hieblmi commented May 23, 2025

Copy link
Copy Markdown
Contributor

Adds the NoWait flag functional options to CloseChannel.

@hieblmi hieblmi requested review from bhandras and guggero May 23, 2025 10:59
Comment thread lightning_client.go Outdated
Value lnwire.MilliSatoshi

/// Timestamp of the payment request.
// / Timestamp of the payment request.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: just remove the third character instead?

Comment thread lightning_client.go Outdated

@bhandras bhandras left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just two nits.

Comment thread lightning_client.go Outdated
Comment thread lightning_client.go
@hieblmi hieblmi force-pushed the no-wait branch 3 times, most recently from 0ebc477 to c92c985 Compare May 24, 2025 11:57
@hieblmi hieblmi changed the title closechannel: add NoWait flag closechannel: add functional options May 24, 2025
@hieblmi hieblmi requested review from bhandras and guggero May 24, 2025 11:58

@bhandras bhandras left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

Comment thread lightning_client.go Outdated
Comment thread lightning_client.go
@guggero guggero merged commit c7caca2 into lightninglabs:master May 26, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants