Replace ledger-get-minibuffer-prompt with built-in format-prompt#477
Open
bcc32 wants to merge 2 commits into
Open
Replace ledger-get-minibuffer-prompt with built-in format-prompt#477bcc32 wants to merge 2 commits into
bcc32 wants to merge 2 commits into
Conversation
basil-conto
reviewed
Jun 12, 2026
6777bdd to
bb4e4c7
Compare
Collaborator
Author
|
(requesting some review due to the introduction of the compat dependency) |
purcell
reviewed
Jun 22, 2026
|
|
||
| ;;; Code: | ||
|
|
||
| ;; Required for `package-lint' to find installed `compat' package and not warn |
Member
There was a problem hiding this comment.
package-lint doesn't need the dependent packages to be installed, it just needs to know they are installable.
Member
|
I'm a bit on the fence about this. On the one hand it would likely be fine to raise the minimum Emacs version required by |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This introduces a dependency on the
compatpackage. Not sure if the othermaintainers think that might be controversial, but doing so would allow many
other things to take advantage of more modern APIs, and faster, while retaining
compatibility with older Emacs versions.