Skip to content

Replace ledger-get-minibuffer-prompt with built-in format-prompt#477

Open
bcc32 wants to merge 2 commits into
ledger:masterfrom
bcc32:format-prompt
Open

Replace ledger-get-minibuffer-prompt with built-in format-prompt#477
bcc32 wants to merge 2 commits into
ledger:masterfrom
bcc32:format-prompt

Conversation

@bcc32

@bcc32 bcc32 commented Jun 10, 2026

Copy link
Copy Markdown
Collaborator

This introduces a dependency on the compat package. Not sure if the other
maintainers think that might be controversial, but doing so would allow many
other things to take advantage of more modern APIs, and faster, while retaining
compatibility with older Emacs versions.

Comment thread tools/lint.el Outdated
@bcc32 bcc32 force-pushed the format-prompt branch 4 times, most recently from 6777bdd to bb4e4c7 Compare June 12, 2026 19:55
@bcc32 bcc32 requested review from jwiegley and purcell June 20, 2026 03:41
@bcc32

bcc32 commented Jun 20, 2026

Copy link
Copy Markdown
Collaborator Author

(requesting some review due to the introduction of the compat dependency)

Comment thread tools/lint.el

;;; Code:

;; Required for `package-lint' to find installed `compat' package and not warn

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

package-lint doesn't need the dependent packages to be installed, it just needs to know they are installable.

@purcell

purcell commented Jun 22, 2026

Copy link
Copy Markdown
Member

I'm a bit on the fence about this. On the one hand it would likely be fine to raise the minimum Emacs version required by ledger-mode to 27.x, or perhaps even 28. Requiring extra packages is slightly more drastic, and while I'm happy compat exists, I don't think it always provides perfect compatibility. I'm not hugely opposed though — depends a bit on what improvements it could yield here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants