Skip to content

chore(Dynamics): deprecate IsForwardInvariant in favour of new Set.IsInvariantOn#41940

Open
mcdoll wants to merge 3 commits into
leanprover-community:masterfrom
mcdoll:isInvariantOn
Open

chore(Dynamics): deprecate IsForwardInvariant in favour of new Set.IsInvariantOn#41940
mcdoll wants to merge 3 commits into
leanprover-community:masterfrom
mcdoll:isInvariantOn

Conversation

@mcdoll

@mcdoll mcdoll commented Jul 20, 2026

Copy link
Copy Markdown
Member

We define a predicate Set.IsInvariantOn that generalizes IsInvariant and as a special case contains IsForwardInvariant. The later is hence removed. We also move IsInvariant into the Set namespace to allow for dot-notation.


Open in Gitpod

@github-actions github-actions Bot added the t-dynamics Dynamical Systems label Jul 20, 2026
@github-actions

github-actions Bot commented Jul 20, 2026

Copy link
Copy Markdown

PR summary 8c2a7cd5df

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff (regex)

+ Set.IsInvariant
+ Set.IsInvariant.isInvariantOn
+ Set.IsInvariantOn
+ Set.isInvariantOn_iff_image
+ Set.isInvariantOn_univ
+ Set.isInvariant_iff_image
+ isInvariantOn_Ici_forwardOrbit
+ restrictNonneg_apply

You can run this locally as follows
## from your `mathlib4` directory:
git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci

## summary with just the declaration names:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh <optional_commit>

## more verbose report:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh long <optional_commit>

The doc-module for scripts/pr_summary/declarations_diff.sh in the mathlib-ci repository contains some details about this script.

Declarations diff (Lean)

Lean-aware diff — post-build, computed from the Lean environment (commit 8c2a7cd).

  • +8 new declarations
  • −0 removed declarations
+Flow.isInvariantOn_Ici_forwardOrbit
+Flow.restrictNonneg_apply
+Set.IsInvariant
+Set.IsInvariant.isInvariantOn
+Set.IsInvariantOn
+Set.isInvariantOn_iff_image
+Set.isInvariantOn_univ
+Set.isInvariant_iff_image

No changes to strong technical debt.

No changes to weak technical debt.

Current commit 8c2a7cd5df
Reference commit d0060d7bbb

This script lives in the mathlib-ci repository. To run it locally, from your mathlib4 directory:

git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci
../mathlib-ci/scripts/reporting/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

t-dynamics Dynamical Systems

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant