Skip to content

fix(GroupTheory/Coprod): fix recursor argument name#41930

Open
plp127 wants to merge 1 commit into
leanprover-community:masterfrom
plp127:aliu/motive-coprod
Open

fix(GroupTheory/Coprod): fix recursor argument name#41930
plp127 wants to merge 1 commit into
leanprover-community:masterfrom
plp127:aliu/motive-coprod

Conversation

@plp127

@plp127 plp127 commented Jul 19, 2026

Copy link
Copy Markdown
Contributor

Fix the argument names of Monoid.Coprod.induction_on' and Monoid.Coprod.induction_on. Name the motive motive and name the minor premises according to their contents.


Open in Gitpod

@plp127 plp127 added the easy < 20s of review time. See the lifecycle page for guidelines. label Jul 19, 2026
@github-actions github-actions Bot added the t-group-theory Group theory label Jul 19, 2026
@github-actions

github-actions Bot commented Jul 19, 2026

Copy link
Copy Markdown

PR summary ec56eae52c

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff (regex)

No declarations were harmed in the making of this PR! 🐙

You can run this locally as follows
## from your `mathlib4` directory:
git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci

## summary with just the declaration names:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh <optional_commit>

## more verbose report:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh long <optional_commit>

The doc-module for scripts/pr_summary/declarations_diff.sh in the mathlib-ci repository contains some details about this script.

Declarations diff (Lean)

Lean-aware diff — post-build, computed from the Lean environment (commit ec56eae).

  • +0 new declarations
  • −0 removed declarations

No declaration differences.


No changes to strong technical debt.

No changes to weak technical debt.

Current commit ec56eae52c
Reference commit c81c5cbb1c

This script lives in the mathlib-ci repository. To run it locally, from your mathlib4 directory:

git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci
../mathlib-ci/scripts/reporting/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@felixpernegger felixpernegger left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think one could find all of these misnamed induction principles quite easily. Are you considering doing that (or did it already)?

@plp127

plp127 commented Jul 19, 2026

Copy link
Copy Markdown
Contributor Author

i think one could find all of these misnamed induction principles quite easily. Are you considering doing that (or did it already)?

I wrote a metaprogram to do this, but it found very many (3000+) candidates, and I had to go through them all manually.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

easy < 20s of review time. See the lifecycle page for guidelines. t-group-theory Group theory

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants