Skip to content

style: merge "List" lines#41926

Open
felixpernegger wants to merge 4 commits into
leanprover-community:masterfrom
felixpernegger:mergelines
Open

style: merge "List" lines#41926
felixpernegger wants to merge 4 commits into
leanprover-community:masterfrom
felixpernegger:mergelines

Conversation

@felixpernegger

@felixpernegger felixpernegger commented Jul 19, 2026

Copy link
Copy Markdown
Contributor

This PR merges all stuff like:

rw [AAA, BBB,
CCC]

to

rw [AAA, BBB, CCC]

when this doesnt break the character limit. In reviews, this is usually adressed to fix (if new ones are generated), so I think it makes sense to do this mathlib wide one time as well. Of course the diff is pretty large, so I can of course split it up if needed.

In some instances it might be a bit more readable not to merge, but I think this is pretty rare.


Open in Gitpod

@github-actions

github-actions Bot commented Jul 19, 2026

Copy link
Copy Markdown

PR summary 637a734c63

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff (regex)

No declarations were harmed in the making of this PR! 🐙

You can run this locally as follows
## from your `mathlib4` directory:
git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci

## summary with just the declaration names:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh <optional_commit>

## more verbose report:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh long <optional_commit>

The doc-module for scripts/pr_summary/declarations_diff.sh in the mathlib-ci repository contains some details about this script.

Declarations diff (Lean -- pending)

Computed after the build finishes.


No changes to strong technical debt.

No changes to weak technical debt.

Current commit 637a734c63
Reference commit d0060d7bbb

This script lives in the mathlib-ci repository. To run it locally, from your mathlib4 directory:

git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci
../mathlib-ci/scripts/reporting/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@felixpernegger
felixpernegger marked this pull request as draft July 19, 2026 15:30
@mathlib-bors

mathlib-bors Bot commented Jul 19, 2026

Copy link
Copy Markdown
Contributor

This pull request is now in draft mode. No active bors state needed cleanup.

While this PR remains draft, bors will ignore commands on this PR. Mark it ready for review before using commands like bors r+ or bors try.

@felixpernegger
felixpernegger marked this pull request as ready for review July 20, 2026 00:30
@grunweg

grunweg commented Jul 20, 2026

Copy link
Copy Markdown
Contributor

Hi! As I said here, I think we shouldn't merge your PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants