style: merge "List" lines#41926
Open
felixpernegger wants to merge 4 commits into
Open
Conversation
PR summary 637a734c63Import changes for modified filesNo significant changes to the import graph Import changes for all files
|
felixpernegger
marked this pull request as draft
July 19, 2026 15:30
Contributor
|
This pull request is now in draft mode. No active bors state needed cleanup. While this PR remains draft, bors will ignore commands on this PR. Mark it ready for review before using commands like |
felixpernegger
marked this pull request as ready for review
July 20, 2026 00:30
Contributor
|
Hi! As I said here, I think we shouldn't merge your PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR merges all stuff like:
rw [AAA, BBB,
CCC]
to
rw [AAA, BBB, CCC]
when this doesnt break the character limit. In reviews, this is usually adressed to fix (if new ones are generated), so I think it makes sense to do this mathlib wide one time as well. Of course the diff is pretty large, so I can of course split it up if needed.
In some instances it might be a bit more readable not to merge, but I think this is pretty rare.