Skip to content

[Merged by Bors] - feat(Analysis/Meromorphic): const_smul lemma - #39833

Closed
wwylele wants to merge 5 commits into
leanprover-community:masterfrom
wwylele:meromorphic-smul
Closed

[Merged by Bors] - feat(Analysis/Meromorphic): const_smul lemma#39833
wwylele wants to merge 5 commits into
leanprover-community:masterfrom
wwylele:meromorphic-smul

Conversation

@wwylele

@wwylele wwylele commented May 25, 2026

Copy link
Copy Markdown
Collaborator

This allows more general scalar type than the existing smul ones


Open in Gitpod

@github-actions github-actions Bot added the t-analysis Analysis (normed *, calculus) label May 25, 2026
@github-actions

github-actions Bot commented May 25, 2026

Copy link
Copy Markdown

PR summary b451909c5f

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff (regex)

+++ const_smul

You can run this locally as follows
## from your `mathlib4` directory:
git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci

## summary with just the declaration names:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh <optional_commit>

## more verbose report:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh long <optional_commit>

The doc-module for scripts/pr_summary/declarations_diff.sh in the mathlib-ci repository contains some details about this script.

Declarations diff (Lean)

Lean-aware diff — post-build, computed from the Lean environment (commit b451909).

  • +6 new declarations
  • −0 removed declarations
+Meromorphic.const_smul
+Meromorphic.fun_const_smul
+MeromorphicAt.const_smul
+MeromorphicAt.fun_const_smul
+MeromorphicOn.const_smul
+MeromorphicOn.fun_const_smul

No changes to strong technical debt.

No changes to weak technical debt.

Current commit b451909c5f
Reference commit 7a40523ade

This script lives in the mathlib-ci repository. To run it locally, from your mathlib4 directory:

git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci
../mathlib-ci/scripts/reporting/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@wwylele wwylele changed the title feat(Analysis/Meromorphoc): const_smul lemma feat(Analysis/Meromorphic): const_smul lemma May 25, 2026

@JonBannon JonBannon left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems fine to me.

Comment thread Mathlib/Analysis/Meromorphic/Basic.lean Outdated
Comment thread Mathlib/Analysis/Meromorphic/Basic.lean Outdated
@mathlib-triage mathlib-triage Bot assigned j-loreaux and unassigned ADedecker Jun 15, 2026

@j-loreaux j-loreaux left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

bors merge

mathlib-bors Bot pushed a commit that referenced this pull request Jun 22, 2026
This allows more general scalar type than the existing `smul` ones
@mathlib-triage mathlib-triage Bot added the ready-to-merge This PR has been sent to bors. label Jun 22, 2026
@mathlib-bors

mathlib-bors Bot commented Jun 22, 2026

Copy link
Copy Markdown
Contributor

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors Bot changed the title feat(Analysis/Meromorphic): const_smul lemma [Merged by Bors] - feat(Analysis/Meromorphic): const_smul lemma Jun 22, 2026
@mathlib-bors mathlib-bors Bot closed this Jun 22, 2026
@wwylele
wwylele deleted the meromorphic-smul branch June 22, 2026 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-to-merge This PR has been sent to bors. t-analysis Analysis (normed *, calculus)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants