style: refine Drawer spacing, tokens, and close icon#86
Draft
Fernando Jesus (fernandorjesus) wants to merge 3 commits into
Draft
style: refine Drawer spacing, tokens, and close icon#86Fernando Jesus (fernandorjesus) wants to merge 3 commits into
Fernando Jesus (fernandorjesus) wants to merge 3 commits into
Conversation
Tighten header/footer/main padding, move close icon to icons.v2 (XIcon), and align title/description typography with current gray/purple tokens. Update stories to match the new header/footer composition.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Add mb-8 to header and drop bottom padding from main; remove leftover bg-red-500 debug class from FromRight story paragraphs.
Drawer no longer accepts a direction prop and always opens from the right. DrawerHeader now renders a back button by default (closes the drawer); passing onBack swaps it for a custom callback instead, and hideBackButton hides it entirely. Also added an action slot for header content.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
p-8→p-6/px-6 py-4) for a more compact layouticons(CloseIcon) toicons.v2(XIcon), matching the ongoing lucide migrationDrawerTitle/DrawerDescriptiontypography with current gray/purple tokens (gray-800/gray-600, smaller sizes)Test plan
biome ci .— passes (pre-existing unrelated file-size warning only)pnpm run type-check— passespnpm run test— 2330/2330 passing, Drawer.tsx at 100% coveragepnpm run build— passes