xdr_codegen: make struct members always named - #8
Merged
Conversation
The members of XdrStruct were defined to be of type Definition. Definition has two variants, named and void. There is no use case for void struct members. Every place in the code that iterated over struct members was just "unwrapping" and either skipping void members or panicking. Since the panicking meant that void struct members were effectively illegal, and since there is no use case for them, it is simpler to just make them not representable by making struct members always a NamedDeclaration.
bertschinger
force-pushed
the
named_struct_members
branch
from
May 28, 2026 17:28
f0bf59e to
f4cd9d0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The members of XdrStruct were defined to be of type Definition. Definition has two variants, named and void.
There is no use case for void struct members. Every place in the code that iterated over struct members was just "unwrapping" and either skipping void members or panicking.
Since the panicking meant that void struct members were effectively illegal, and since there is no use case for them, it is simpler to just make them not representable by making struct members always a NamedDeclaration.