Skip to content

detect self referential optionals hidden behind typedefs #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
alambert-lanl wants to merge 1 commit into from
Closed

detect self referential optionals hidden behind typedefs #24

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 10 additions & 5 deletions xdr_codegen/src/codegen/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -704,11 +704,16 @@ impl XdrType {
return false;
};

let ValidatedDefinition::Struct(ref s) = *tab.lookup_definition(n) else {
return false;
};

s.self_referential_optional
match tab.lookup_definition(n) {
ValidatedDefinition::TypeDef(xdr_type_def) => match &xdr_type_def.decl.kind {
DeclarationKind::Scalar(xdr_type) | DeclarationKind::Optional(xdr_type) => {
xdr_type.self_referential_optional(tab)
}
_ => false,
},
ValidatedDefinition::Struct(s) => s.self_referential_optional,
_ => false,
}
}
fn optional_type_name(&self, tab: &ValidatedSymbolTable) -> String {
let inner_type = self.as_type_name(tab);
Expand Down
Loading