Feature/serialize get width#22
Merged
bertschinger merged 1 commit intoJun 22, 2026
Merged
Conversation
Contributor
Author
|
0e0f7b3 to
c8c4856
Compare
Contributor
Author
|
The first 4 commits of the series are dependencies that should be split out into individual commits |
d5193be to
0a1c8da
Compare
Contributor
Author
|
Alright, this feature is gtg |
bertschinger
requested changes
Jun 22, 2026
0a1c8da to
24d093c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds generation of
get_width(&self) -> usizefunctions to structures passed into serialization routines. With this addition, one can precompute the encoded width of xdr structures and thus can guarantee the success of serialization routines as well as minimize allocations.