MAINT: remove fastparquet compression for bubblesam parquet#39
Open
adamwitmer wants to merge 1 commit into
Open
MAINT: remove fastparquet compression for bubblesam parquet#39adamwitmer wants to merge 1 commit into
fastparquet compression for bubblesam parquet#39adamwitmer wants to merge 1 commit into
Conversation
* modify handling of type coercions for saving * reshape contour array when loading in test
Collaborator
Author
|
I also opened issue #40 to make a note of the need to simplify data structure handling for saving as parquet, which I did not address in this PR to keep the scope limited to changes related to |
Collaborator
|
Can you provide a brief/clear explanation of why you need to remove |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In line with #4 (comment), this PR simplifies
bubblesamparquet saving/loading by removing the use offastparquetengine, which saved objects as strings. This change will also simplify parquet loading in PR #5 and remove the need for theastmodule there.