Skip to content

CI: cache microsoft fonts #35

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tylerjereddy merged 5 commits into from
Jun 11, 2026
Merged

CI: cache microsoft fonts #35

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
8de225b
CI: cache microsoft fonts
Jun 9, 2026
815cfb9
MAINT, CI: address AI reviewer comment
Jun 9, 2026
864a596
CI: use github actions cache hash
Jun 11, 2026
b5d74b9
MAINT: fix hash version comment
adamwitmer Jun 11, 2026
189da6d
CI: modify cache logic to check for successful download
adamwitmer Jun 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 11 additions & 2 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,13 +25,22 @@ jobs:
python -m pip install -v ".[dev]"
mypy neat_ml
ruff check neat_ml
- name: install fonts
- name: cache fonts
id: cache-fonts
if: runner.os == 'Linux'
uses: actions/cache@v5

@tylerjereddy tylerjereddy Jun 10, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is best practice to use the hash rather than the release tag for security reasons (tags are often mutable), followed by a short comment with the tag/version number.

As an example of how to do this, see pandas CI config here:
https://github.com/pandas-dev/pandas/blob/main/.github/workflows/wheels.yml#L70

The rest of this seems "ok" now.

@adamwitmer adamwitmer Jun 11, 2026

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I modified the cache fonts step to use the github/actions/cache hash instead of the version tag. I cloned the github actions repo and checked out v5.0.5 to find the commit hash associated with the version.

@adamwitmer adamwitmer Jun 11, 2026

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As noted during in person conversation, I didnt check that the version tag and hash number were aligned in the CI file. I have updated the comment to reference the correct tag (v5.0.5).

with:
path: /usr/share/fonts/truetype/msttcorefonts/
key: ${{ runner.os }}-msttcorefonts-v1
- name: install fonts
if: runner.os == 'Linux' && steps.cache-fonts.outputs.cache-hit != 'true'
run: |
echo ttf-mscorefonts-installer msttcorefonts/accepted-mscorefonts-eula select true | sudo debconf-set-selections
sudo apt-get update
sudo apt-get install -y ttf-mscorefonts-installer || true
Comment thread
greptile-apps[bot] marked this conversation as resolved.
Outdated
sudo fc-cache -f -v
- name: refresh font cache
if: runner.os == 'Linux'
run: sudo fc-cache -f -v
- name: test
run: |
cd /tmp && python -m pytest --pyargs neat_ml --cov=neat_ml --cov-report=term-missing
Loading