[langchain-ibm/feat]: Support for additional urls, make instance_id as optional - #102
Merged
Mateusz Szewczyk (MateuszOssGit) merged 6 commits intoAug 28, 2025
Conversation
…-optional # Conflicts: # libs/ibm/pyproject.toml
…-optional # Conflicts: # libs/ibm/langchain_ibm/agent_toolkits/utility/toolkit.py # libs/ibm/langchain_ibm/chat_models.py # libs/ibm/langchain_ibm/embeddings.py # libs/ibm/langchain_ibm/llms.py # libs/ibm/langchain_ibm/rerank.py
Mateusz Szewczyk (MateuszOssGit)
changed the title
instance_id as optional [DO NOT MERGE YET]instance_id as optional
Mateusz Switala (Mateusz-Switala)
approved these changes
Aug 28, 2025
Mateusz Switala (Mateusz-Switala)
left a comment
Mateusz Switala (Mateusz-Switala)
left a comment
Collaborator
There was a problem hiding this comment.
LGTM
Mateusz Szewczyk (MateuszOssGit)
deleted the
dev-add-support-external-urls-instance-id-as-optional
branch
August 28, 2025 08:52
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes:
instance_idas optional parameter when initialising on CPDNote:
Marge when
1.3.36version ofibm_watsonx_aiwill ba available on pypi.