fix(index): align distributed scalar index parameters#5250
Open
ddupg wants to merge 1 commit into
Open
Conversation
ddupg
marked this pull request as ready for review
July 21, 2026 14:20
ddupg
force-pushed
the
fix/ddu-310-scalar-index-contract
branch
from
July 22, 2026 11:35
52e65e0 to
f286375
Compare
ddupg
force-pushed
the
fix/ddu-310-scalar-index-contract
branch
from
July 22, 2026 11:38
f286375 to
5536fa6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
index_typeaccepts either a string orIndexConfig, but the two forms previously behaved differently:IndexConfighad no matching preflight check, so unsupported inputs could reach the legacy or worker path instead of failing locally."FTS"worked as a string alias, butIndexConfig("fts", parameters)was passed to Core as the literalftsplugin name. Core expectsinverted, so that form failed.IndexConfigskipped driver-side validation, so equivalent requests could accept different fields or fail at different stages.This change gives both forms one driver-side contract: normalize the logical type, preserve the caller-owned
IndexConfig, map FTS configs toinverted, validate fields against Core's rules, and reject unsupported types before Ray workers start.Validation
tests/test_vector_index_options.pyplus three focused integration tests — 36 passedruff check lance_ray/index.py tests/test_vector_index_options.py tests/test_distributed_indexing.pygit diff --check