Skip to content

fix(index): align distributed scalar index parameters#5250

Open
ddupg wants to merge 1 commit into
lance-format:mainfrom
ddupg:fix/ddu-310-scalar-index-contract
Open

fix(index): align distributed scalar index parameters#5250
ddupg wants to merge 1 commit into
lance-format:mainfrom
ddupg:fix/ddu-310-scalar-index-contract

Conversation

@ddupg

@ddupg ddupg commented Jul 21, 2026

Copy link
Copy Markdown
Contributor

Summary

index_type accepts either a string or IndexConfig, but the two forms previously behaved differently:

  • String inputs required canonical uppercase names and used separate driver-side checks. IndexConfig had no matching preflight check, so unsupported inputs could reach the legacy or worker path instead of failing locally.
  • "FTS" worked as a string alias, but IndexConfig("fts", parameters) was passed to Core as the literal fts plugin name. Core expects inverted, so that form failed.
  • Field validation ran only for strings and covered only part of Core's accepted field shapes. IndexConfig skipped driver-side validation, so equivalent requests could accept different fields or fail at different stages.

This change gives both forms one driver-side contract: normalize the logical type, preserve the caller-owned IndexConfig, map FTS configs to inverted, validate fields against Core's rules, and reject unsupported types before Ray workers start.

Validation

  • tests/test_vector_index_options.py plus three focused integration tests — 36 passed
  • ruff check lance_ray/index.py tests/test_vector_index_options.py tests/test_distributed_indexing.py
  • git diff --check

@github-actions github-actions Bot added the enhancement New feature or request label Jul 21, 2026
@ddupg
ddupg marked this pull request as ready for review July 21, 2026 14:20
@ddupg ddupg changed the title feat: support zonemap in distributed scalar indexing fix(index): align distributed scalar index parameters Jul 22, 2026
@github-actions github-actions Bot added the bug Something isn't working label Jul 22, 2026
@ddupg
ddupg force-pushed the fix/ddu-310-scalar-index-contract branch from 52e65e0 to f286375 Compare July 22, 2026 11:35
@ddupg
ddupg force-pushed the fix/ddu-310-scalar-index-contract branch from f286375 to 5536fa6 Compare July 22, 2026 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant