fix(core): allow referencing never-update columns in ON CONFLICT DO UPDATE WHERE clause#1913
Open
cschanhniem wants to merge 1 commit into
Open
Conversation
…PDATE WHERE clause When a column has its update type set to never (e.g. `ColumnType<Date, never, Date>`), the WHERE clause of `onConflict(...).doUpdateSet(...).where(...)` failed to offer that column as a reference because `OnConflictDatabase` wrapped the table type in `Updateable`, which strips columns whose `UpdateType` is never. Fixed by introducing `OnConflictDatabaseForWhere` that preserves all columns for WHERE clause reference purposes while keeping `OnConflictDatabase` for the `doUpdateSet` parameter (where filtering non-updateable columns is correct). Closes kysely-org#1409
|
Someone is attempting to deploy a commit to the Kysely Team Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem: When a column has its update type set to
never(e.g.ColumnType<Date, never, Date>), the WHERE clause ofonConflict(...).doUpdateSet(...).where(...)fails to offer that column as a reference.Root cause:
OnConflictDatabasewraps the table type inUpdateable, which strips columns whoseUpdateTypeisnever. This is correct for thedoUpdateSetparameter (you can't update those columns) but incorrect for the WHERE clause (you can still filter on them).Fix: Introduced
OnConflictDatabaseForWherethat preserves all columns for WHERE clause reference purposes.Fixes #1409