-
Notifications
You must be signed in to change notification settings - Fork 421
feat: Add NULLIF() implementation
#1676
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
bakasmarius
wants to merge
23
commits into
kysely-org:master
Choose a base branch
from
bakasmarius:feature/1429-add-nullif-implementation
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+103
−0
Open
Changes from 19 commits
Commits
Show all changes
23 commits
Select commit
Hold shift + click to select a range
b87a343
feat: add `NULLIF()` implementation
bakasmarius 28b376a
Merge branch 'master' into feature/1429-add-nullif-implementation
bakasmarius 1b29008
fix: update import
bakasmarius 3c25fee
fix: add missing import
bakasmarius 0bad547
Merge branch 'master' into feature/1429-add-nullif-implementation
bakasmarius b72c1b0
Merge branch 'master' into feature/1429-add-nullif-implementation
bakasmarius 9ec8757
Merge branch 'master' into feature/1429-add-nullif-implementation
bakasmarius 630205c
Merge branch 'master' into feature/1429-add-nullif-implementation
bakasmarius 4359bcc
Merge branch 'master' into feature/1429-add-nullif-implementation
bakasmarius c1807d7
Merge branch 'master' into feature/1429-add-nullif-implementation
bakasmarius bf09ae4
Merge branch 'master' into feature/1429-add-nullif-implementation
bakasmarius 64f29d7
chore: remove operation node
bakasmarius c9ed3bf
refactor: move `nullif` to `FunctionModule` and update types
bakasmarius 2b178ab
test: simplify nullif tests
bakasmarius 979674d
Merge branch 'master' into feature/1429-add-nullif-implementation
bakasmarius d22320b
Merge branch 'master' into feature/1429-add-nullif-implementation
bakasmarius f61c706
Merge branch 'master' into feature/1429-add-nullif-implementation
bakasmarius 019f28b
chore: change `var` to `const`
bakasmarius 53a7d27
Merge branch 'master' into feature/1429-add-nullif-implementation
bakasmarius b0607e4
Discard changes to src/operation-node/operation-node-transformer.ts
igalklebanov bb89630
Discard changes to src/operation-node/operator-node.ts
igalklebanov 4cbaccf
Merge branch 'master' into feature/1429-add-nullif-implementation
bakasmarius 1912c1b
Merge branch 'master' into feature/1429-add-nullif-implementation
bakasmarius File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,46 @@ | ||
| import { Kysely, sql } from '../../../dist/cjs' | ||
|
|
||
| import { | ||
| destroyTest, | ||
| initTest, | ||
| TestContext, | ||
| expect, | ||
| Database, | ||
| clearDatabase, | ||
| DIALECTS, | ||
| } from './test-setup.js' | ||
|
|
||
| for (const dialect of DIALECTS) { | ||
| describe(`${dialect} null if`, () => { | ||
| let ctx: TestContext | ||
| let db: Kysely<Database> | ||
|
|
||
| before(async function () { | ||
| ctx = await initTest(this, dialect) | ||
|
|
||
| db = ctx.db as any | ||
| }) | ||
|
|
||
| afterEach(async () => { | ||
| await clearDatabase(ctx) | ||
| }) | ||
|
|
||
| after(async () => { | ||
| await destroyTest(ctx) | ||
| }) | ||
|
|
||
| it('should return correct values for NULLIF without selection from a table', async () => { | ||
| const result = await db | ||
| .selectNoFrom(({ fn }) => [ | ||
| fn.nullif(sql.lit('2000-01-01'), '2000-01-01').as('null_dates_equal'), | ||
| fn.nullif(sql.lit(1), 2).as('null_numbers_different'), | ||
| ]) | ||
| .executeTakeFirstOrThrow() | ||
|
|
||
| expect(result).to.eql({ | ||
| null_dates_equal: null, | ||
| null_numbers_different: dialect === 'mysql' ? '1' : 1, | ||
| }) | ||
| }) | ||
| }) | ||
| } |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.