[Addon] migrate cloudshell to native helmchart#789
Open
preko-p wants to merge 1 commit into
Open
Conversation
Signed-off-by: preko-p <278021202+preko-p@users.noreply.github.com>
Author
|
I dug into the failing Addon-test rather than pushing a workaround. The failure looks like a CI/core baseline mismatch, not a catalog-local template error:
I checked this repo for an existing native So I think this needs maintainer direction: should the catalog CI/core baseline be updated to a KubeVela version that includes native |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of your changes
Migrates the
cloudshelladdon from the FluxCD-backedhelmcomponent to the native KubeVelahelmchartcomponent as a scoped worked example for:Fixes #787
This keeps the existing chart, chart version, release name, release namespace, and values:
cloudttyhttps://cloudtty.github.io/cloudtty0.3.0cloudshell-operatorvela-systemIt also bumps the addon metadata version from
0.0.10to0.0.11and removes the now-unusedfluxcddependency.Special review notes:
helmchartschema was checked against current KubeVela core sources/docs forchart.source,repoURL,version,release, and top-levelvalues.cloudtty0.3.0does not ship a Helmcrds/directory; its CRD is rendered through a normal chart template gated by the existinginstallCRDs: truedefault value, so I did not addoptions.includeCRDs.helmchartdoes not exactly replicate FluxupgradeCRDsemantics.How has this code been tested?
Ran locally:
make check-addon-semvergit diff --checkrg -n "fluxcd|GitRepository|Kustomization|Bucket|OCIRepository|HelmRepository|type:\s*helm$" addons/cloudshellThe final grep returned no residual FluxCD or exact old
type: helmreferences underaddons/cloudshell.Not run locally:
velarender/install validationhelmvalidationcuevalidationThose tools were not available in my local runner environment.
Checklist
I have:
[Addon],[example]or[Doc]).versioninmetadata.yamlto generate a new version.Verified Addon promotion rules
This PR does not promote an experimental addon to verified.
Summary by cubic
Migrates the
cloudshelladdon from Flux-backedhelmto native KubeVelahelmchartfor simpler management and nofluxcddependency. Fixes #787.Refactors
helmchart(chartcloudtty, repohttps://cloudtty.github.io/cloudtty, version0.3.0).release.namecloudshell-operatorandrelease.namespacevela-system; keep existing values.fluxcdfromdependencies; bump addon version to0.0.11.installCRDs: true); nooptions.includeCRDsadded.Written for commit 2db7ff7. Summary will update on new commits.