Add MultiKueue e2e test - #6429
Conversation
|
Skipping CI for Draft Pull Request. |
kubernetes-prow
Bot
added
release-note-none
kubernetes-prow
Bot
added
cncf-cla: yes
|
/assign |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6429 +/- ##
=======================================
Coverage 44.07% 44.07%
=======================================
Files 289 289
Lines 25382 25384 +2
=======================================
+ Hits 11187 11189 +2
Misses 13419 13419
Partials 776 776 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
| } | ||
|
|
||
| // InstallOCIHelmChart installs an OCI Helm chart on a workload cluster. | ||
| func InstallOCIHelmChart(ctx context.Context, clusterProxy framework.ClusterProxy, namespace, chartName, releaseName string, extraArgs ...string) { |
There was a problem hiding this comment.
This func is really similar to InstallHelmChart from the KubeRay tests. Maybe we could consolidate them.
| - 🟢 [pull-cluster-api-provider-azure-verify] `make verify` | ||
| - [pull-cluster-api-provider-azure-e2e-exp] | ||
| * `GINKGO_FOCUS=".*AKS.*" GINKGO_SKIP="" ./scripts/ci-e2e.sh` | ||
| * The opt-in MultiKueue AKS stress suite can be targeted with `GINKGO_FOCUS="MultiKueue" GINKGO_SKIP="" ./scripts/ci-e2e.sh`. It provisions one manager and three worker AKS clusters by default; override `MULTIKUEUE_WORKER_CLUSTER_COUNT`, `MULTIKUEUE_STRESS_JOB_COUNT`, `MULTIKUEUE_AKS_FLAVOR`, `KUEUE_VERSION`, or `JOBSET_VERSION` as needed. |
There was a problem hiding this comment.
(OT: I noticed while looking at this jobs.md file that it's not accurate any more. Specifically, it still mentions the nonexistent e2e-exp job.)
| } | ||
|
|
||
| // MultiKueueSpec installs Kueue and JobSet on CAPZ-managed AKS clusters and validates MultiKueue dispatch. | ||
| func MultiKueueSpec(ctx context.Context, inputGetter func() MultiKueueSpecInput) { |
There was a problem hiding this comment.
This is a hefty spec overall, requiring four AKS clusters and kueue and jobset installs, run through several sequential tests with long sleeps and 15m intervals. I'm just hoping it fits within the overall timeout.
| } | ||
|
|
||
| func (e *multiKueueEnvironment) validateAllAtOnceFanOut(ctx context.Context) { | ||
| job := newMultiKueueBatchJob("multikueue-all-at-once", e.setup.Namespace, "2", "sleep 300") |
There was a problem hiding this comment.
I think this relies on kueue 0.18.2 defaulting to the AllAtOnce dispatcher? Maybe would be safer to set spec.dispatcherName explicitly.
|
/test pull-cluster-api-provider-azure-e2e-multikueue |
3 participants
What type of PR is this?
/kind feature
What this PR does / why we need it:
This PR adds an e2e for AKS clusters running MultiKueue.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #6418
Special notes for your reviewer:
TODOs:
Release note: