Added grafana loki dashboard and restructured repo - #2
Open
Chinwendu20 wants to merge 2 commits into
Open
Conversation
Signed-off-by: Ononiwu Maureen <amaka013@gmail.com>
nyrahul
requested changes
Jun 5, 2023
nyrahul
left a comment
nyrahul
left a comment
There was a problem hiding this comment.
Thanks for this restructuring. Please check comments.
Comment on lines
+18
to
+19
| - [ELK-kafka stack](https://github.com/Chinwendu20/kubearmor-dashboards/tree/otel/kubearmor-kafka-elk-stack) | ||
| - [Grafana-loki stack](https://github.com/Chinwendu20/kubearmor-dashboards/tree/otel/kubearmor-grafana-loki) |
There was a problem hiding this comment.
Please do not use personal repo targets. You can use relative paths.
|
|
||
| ### Steps | ||
| 1. Follow [this tutorial](https://github.com/kubearmor/KubeArmor/blob/ce18fee4f87be7786dc1275aeb94ab7096c8b590/getting-started/deployment_guide.md#L20-L19) to set up Kubearmor | ||
| 2. Follow this [tutorial](https://github.com/Chinwendu20/OTel-receiver/blob/otel/example/tutorial.md#create-a-custom-opentelemetry-collector-distribution) to create an opentelemetry custom collector. |
Author
There was a problem hiding this comment.
Thank you. Here just that the tutorial file is currently in my personal repo as my PR on the receiver has not yet been merged in kubearmor's org
rajaSahil
reviewed
Jun 5, 2023
Comment on lines
+182
to
+185
| "displayLabels": [ | ||
| "percent", | ||
| "name" | ||
| ], |
There was a problem hiding this comment.
Is this required, since we are using legends anyway? And displaying labels for a pie chart can lead to overlapping.
Comment on lines
+248
to
+251
| "displayLabels": [ | ||
| "percent", | ||
| "name" | ||
| ], |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR restructures the repo to reflect its current purpose and also includes the grafana loki dashboard