forked from Nerwyn/custom-card-features
-
Notifications
You must be signed in to change notification settings - Fork 0
Add dynamic dropdown/selector options from entity attributes and templates (Ref #137) #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
kristofferR
wants to merge
8
commits into
main
Choose a base branch
from
dynamic-dropdown-options
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 3 commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
3d7a69e
Add dynamic dropdown and selector options from attributes and templates
kristofferR c3c0f7e
Address PR review feedback for dynamic dropdown options
kristofferR 6180aa3
Refine dynamic options: preserve numeric values, honor optionType at …
kristofferR 9486e5b
Reduce option template section to header and edit button
kristofferR 3a39c57
Use 'default' for optionType and define it as a const/type
kristofferR 8cc2178
Don't generate set_preset_mode defaults for humidifiers
kristofferR a4eca89
Let an explicit dynamic source override a stale options array
kristofferR f343f58
Simplify parseOptionsList to array + delimited-string handling
kristofferR File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Large diffs are not rendered by default.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧹 Nitpick | 🔵 Trivial | ⚡ Quick win
Clarify the blank
options_attributesyntax in the example.Line 2537 shows
options_attribute:with no value after the colon. While this is valid YAML (parses asnull), it may confuse readers. Consider either:optionsattribute"options_attributekey at all (since the docs state select/input_select default tooptions)The second option would be clearer and more consistent with the "you can leave the value blank and omit
option_template" phrasing in the text above.📝 Clearer example
```yaml - type: dropdown entity_id: input_select.scene - options_attribute:Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In
@README.mdaround lines 2532 - 2538, The example shows an emptyoptions_attribute:which is valid YAML but confusing; update the snippet forclarity by removing the
options_attributeline entirely (sinceselect/input_select default to the
optionsattribute) or replace it with aninline comment like
# uses default "options" attributeso readers understandthis signals the default behavior for
select/input_select(referenceoptions_attribute,option_template,options, and the example entityinput_select.scene).