Fix image processing in xcassets.py - #994
Merged
Merged
Conversation
AndreMiras
approved these changes
Apr 18, 2026
AndreMiras
left a comment
AndreMiras
left a comment
Member
There was a problem hiding this comment.
LGTM, thanks for the scoped fix
AndreMiras
added a commit
that referenced
this pull request
Apr 18, 2026
Cover the two behavior changes from PR #994: - _buildimage must not crash on palette-mode PNGs ("P") - _generate must invoke sips with -z H W (force exact square) instead of -Z max (bounding box only) Plus baseline coverage for _buildimage padding/resize and the launchimage code path. Tests run on Linux (no sips required) by mocking sh.sips for the icon path. Wire a new `unit_tests` job into the CI workflow running on ubuntu-latest. Kept off macOS on purpose: the absence of `sips` and friends enforces hermetic mocking in the unit layer, and Ubuntu runners are ~10x cheaper and faster. macOS integration coverage stays in the existing build_python3_kivy* jobs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
So, here is a clean PR to just update the
_generateand_buildimagealgorithm of xcassets so images are generated correctly without any size conflicts.Details of changes:
.convert("RGBA")in line 676 to prevent pillow crashes while reading an image.-Zto-zand passed the dimension twice (c, c) in line 706. The old-Zflag only constrained the maximum dimension while keeping the original aspect ratio, which often resulted in the wrong overall dimensions. The lowercase-zstrictly forces the exact height and width required by Xcode.