fix: Remove cython from install_requirements - #2049
Open
C0rn3j wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This project does not require
cythonto run from my understanding.But since it is included as a runtime dependency,
pip checkfails on it:This PR thus removes it from the deps.
To address the removed comment - if a downstream project still requires cython to be installed as a runtime dependency, add a runtime dependency to the downstream project instead of implementing workarounds elsewhere.
If kivy-ios still requires cython, it's missing in https://github.com/kivy/kivy-ios/blob/892c4b72ee4eb3537310b0694d5fb73cb6a18d53/requirements.txt
If python-4-android still requires cython, it's missing in https://github.com/kivy/python-for-android/blob/d156b3df891b54239d039c3f5af0dc8d42117b0e/setup.py#L21-L25
The Dockerfile even tries to hack its own Cython version in(why, it's currently pulling it from the dependencies, no?), I presume that is equally wrong but wasn't sure, so this PR doesn't address it - I can tack it on if needed:
buildozer/Dockerfile
Line 84 in 105543d