fix: replace 5 bare except clauses with except Exception - #2023
Merged
Conversation
Changed: buildozer/targets/android.py
There was a problem hiding this comment.
Pull request overview
This PR improves error-handling safety in the Android target by replacing 5 bare except: clauses with except Exception: in buildozer/targets/android.py, avoiding accidental suppression of BaseException subclasses (e.g., KeyboardInterrupt, SystemExit) while preserving the existing fallback behaviors.
Changes:
- Replace a bare exception handler in
_sdkmanagerproxy parsing withexcept Exception. - Replace bare exception handlers in Windows Java setup, version parsing, build hooks, and project.properties writing with
except Exception. - Ensure there are no remaining
except:occurrences inbuildozer/targets/android.py.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
AndreMiras
approved these changes
May 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces 5 bare
except:withexcept Exception:inbuildozer/targets/android.py.