Skip to content

Refactor IME handling in window_on_textedit method #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Novfensec wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Refactor IME handling in window_on_textedit method #3

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
48 changes: 38 additions & 10 deletions kivy/uix/textinput.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3057,26 +3057,54 @@ def _unbind_keyboard(self):
super()._unbind_keyboard()
Window.unbind(on_textedit=self.window_on_textedit)


def window_on_textedit(self, window, ime_input):
if self._ime_composition:
ci = self.cursor_index()
len_ime = len(self._ime_composition)

self._selection_from = max(0, ci - len_ime)
self._selection_to = ci
self._selection = True
if not self._lines:
self._refresh_text(self.text)

if self._selection:
self.delete_selection()

if ime_input:
if self._selection:
current_ci = self.cursor_index()
cursor_restored = False

if self._ime_composition:
ci = getattr(
self, "_ime_absolute_cursor", self.cursor_index(self._ime_cursor)
)
start_ci = max(0, ci - len(self._ime_composition))

if self.text[start_ci:ci] == self._ime_composition:
self._selection_from = start_ci
self._selection_to = ci
self._selection = True
self.delete_selection()

if current_ci >= ci:
current_ci -= len(self._ime_composition)
elif current_ci > start_ci:
current_ci = start_ci
cursor_restored = True

else:
start_ci_curr = max(0, current_ci - len(self._ime_composition))
if self.text[start_ci_curr:current_ci] == self._ime_composition:
self._selection_from = start_ci_curr
self._selection_to = current_ci
self._selection = True
self.delete_selection()

current_ci = start_ci_curr
cursor_restored = True

if cursor_restored:
self.cursor = self.get_cursor_from_index(current_ci)

if ime_input:
self.insert_text(ime_input)

self._ime_composition = ime_input
self._ime_cursor = self.cursor
self._ime_absolute_cursor = self.cursor_index()

def on__hint_text(self, instance, value):
self._refresh_hint_text()
Expand Down