WIP: Enables definition of default plugins#799
Draft
noseglasses wants to merge 1 commit into
Draft
Conversation
Default plugins are those that are automatically added to the list of plugins considered by KALEIDOSCOPE_INIT_PLUGINS(...). They can either be defined to precede or trail the list defined by KALEIDOSCOPE_INIT_PLUGINS(...). This commit adds the necessary infrastructure but does not add any default plugins by itself. Signed-off-by: Florian Fleissner <florian.fleissner@inpartik.de>
noseglasses
changed the title
Contributor
|
I feel a bit torn on this. On one hand, a list of mandatory plugins can be useful in certain cases - and that's where I'm torn: in certain cases. On a per-device basis, I'd see use for it. If it's global, then nope, we should not do that. What use-case did you have in mind for this feature? |
Contributor
|
Aha, #801. I'll go and look there, before commenting on this further. |
obra
marked this pull request as draft
December 21, 2020 21:47
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This requires #800 to work.
Default plugins are those that are automatically added to the list
of plugins considered by KALEIDOSCOPE_INIT_PLUGINS(...).
They can either be defined to precede or trail the list defined by
KALEIDOSCOPE_INIT_PLUGINS(...).
This commit adds the necessary infrastructure but does not add any
default plugins by itself.
Signed-off-by: Florian Fleissner florian.fleissner@inpartik.de