WIP: An intrusive boilerplate-free Focus/EEPROM storage class#712
Draft
noseglasses wants to merge 1 commit into
Draft
WIP: An intrusive boilerplate-free Focus/EEPROM storage class#712noseglasses wants to merge 1 commit into
noseglasses wants to merge 1 commit into
Conversation
This is an example of how Focus/EEPROM handling of individual
parameters could be implemented in a non-boilerplate fashion.
A new header focus_eeprom.h contains two template classes
that allow to add Focus/EEPROM handling both to members of
base classes (ReferenceFocusEEPROMWrapper)
and to define new members in derived classes
(ValueFocusEEPROMWrapper).
Using the wrapper classes is intrusive in a sense that
it requires classes (plugins) to be modified to add
Focus/EEPROM capability.
Warning: The code compiles but was not thoroughly tested.
It is just meant as an example how things could
be done and a basis for discussion.
Signed-off-by: Florian Fleissner <florian.fleissner@inpartik.de>
noseglasses
changed the title
Contributor
obra
marked this pull request as draft
December 21, 2020 21:46
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an example of how Focus/EEPROM handling of individual
parameters could be implemented in a non-boilerplate fashion.
A new header focus_eeprom.h contains two template classes
that allow to add Focus/EEPROM handling both to members of
base classes (ReferenceFocusEEPROMWrapper)
and to define new members in derived classes
(ValueFocusEEPROMWrapper).
Using the wrapper classes is intrusive in a sense that
it requires classes (plugins) to be modified to add
Focus/EEPROM capability.
Warning: The code compiles but was not thoroughly tested.
It is just meant as an example how things could
be done and a basis for discussion.
Signed-off-by: Florian Fleissner florian.fleissner@inpartik.de