fix(dns): use dot separator for localtargets prefix with backward compatibility - #2401
Open
AruneshDwivedi wants to merge 2 commits into
Open
Conversation
…patibility The localtargets-<host> naming scheme could produce DNS labels exceeding the 63-character limit when the hostname's first label was long enough. Changed the separator from '-' to '.' so 'localtargets' becomes its own DNS label, keeping the original hostname labels intact. Fall back to legacy dash-prefix naming when the new prefix returns no records, ensuring backward compatibility during migration. Fixes k8gb-io#2366 Signed-off-by: Arunesh Dwivedi <arunesh.devops@gmail.com>
AruneshDwivedi
requested review from
abaguas,
donovanmuller,
elohmrow,
jkremser,
k0da,
kuritka and
ytsarev
as code owners
June 29, 2026 08:34
✅ Deploy Preview for k8gb-preview ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
…d chainsaw The localtargets- prefix became localtargets. in the controller, but the unit tests, weight test, and chainsaw step template still asserted the old dash form, so the validation test, weight test, and every chainsaw playground failed. Update the expected names to the dot form and widen the over-long-label test host to 64 chars since the dot splits the prefix into its own label. Signed-off-by: Arunesh Dwivedi <arunesh.dwivedi@example.com>
Author
|
The chainsaw failure wasn't environmental — the step template and unit tests still asserted the old localtargets- dash prefix while the controller now publishes localtargets. with a dot, so I updated the tests, weight test, and chainsaw init to the new form. The over-long-label test now uses a 64-char host because the dot splits the prefix into its own label. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The localtargets- naming scheme could produce DNS labels exceeding the 63-character limit when the hostname's first label was long enough. Changed the separator from '-' to '.' so 'localtargets' becomes its own DNS label, keeping the original hostname labels intact.
Falls back to legacy dash-prefix naming when the new prefix returns no records, ensuring backward compatibility during migration.
Fixes #2366