[feat] Allow all k8 service types#2224
Draft
Piroddi wants to merge 2 commits into
Draft
Conversation
Signed-off-by: Kelvin Piroddi <kpiroddi@gmail.com>
✅ Deploy Preview for k8gb-preview ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Signed-off-by: Kelvin Piroddi <kpiroddi@gmail.com>
Contributor
|
@Piroddi thanks for this! Do you want to continue with it? |
Contributor
Author
|
Hi @elohmrow Yes sorry, I do want to complete this. Currently having to maintain two Service's as k8gb forcing LoadBalancer types. Will put together final code and tests & open up PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow non LoadBalancer types to be referenced if the
k8gb.io/exposed-ip-addressesannotation is set for these services