Skip to content

Drop juspay/xterm.js fork — both fixes are upstream #979

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
srid merged 3 commits into from
May 26, 2026
Merged

Drop juspay/xterm.js fork — both fixes are upstream #979

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5f07cf1
chore(deps): switch xterm from juspay fork to upstream master betas
srid May 26, 2026
25dfb79
refactor(hickey): xtermjs-perf blog snippet now describes upstream
srid May 26, 2026
e536cf8
chore(nix): refresh pnpmDeps hash after xterm beta switch
srid May 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion default.nix
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ let
# hash-fresh` enforces this stays in sync with pnpm-lock.yaml by forcing
# fetchPnpmDeps to re-execute (--rebuild), so stale artifacts in the
# binary cache can't silently satisfy a hash that no longer matches.
hash = "sha256-qwfcEvHlx0AMwl8OJP1zecPDP+n2C0+r1t4zjZpiH1U=";
hash = "sha256-3PHwtkW+K7ciV5GY++U/o0aAnPkTH07jff4XiaznzhY=";
fetcherVersion = 3;
};

Expand Down
4 changes: 2 additions & 2 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,8 @@
"fast-uri": "3.1.2",
"ip-address": "10.1.1",
"@anthropic-ai/sdk": "^0.91.1",
"@xterm/xterm": "github:juspay/xterm.js#fix/kolu-xterm-fixes-built",
"@xterm/addon-webgl": "github:juspay/xterm.js#fix/kolu-xterm-fixes-built&path:/addons/addon-webgl"
"@xterm/xterm": "6.1.0-beta.225",
"@xterm/addon-webgl": "0.20.0-beta.224"
}
}
}
34 changes: 18 additions & 16 deletions pnpm-lock.yaml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

14 changes: 9 additions & 5 deletions website/src/content/blog/xtermjs-perf.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -218,15 +218,19 @@ retainer-walking, and wrong turns to find. That's the shape of this
kind of work; the ratio of code-volume to investigation-time is
always roughly zero.

I consume them via the juspay/xterm.js fork and `pnpm.overrides`,
stacked as a Kolu-consumption branch:
While these were unreleased, I consumed them via a `juspay/xterm.js`
fork pinned in `pnpm.overrides`. #5817 has since merged upstream, and
#5821 was closed in favour of the equivalent
[#5831](https://github.com/xtermjs/xterm.js/pull/5831) (clear the
observer reference on dispose); both shipped in the upstream
`6.1.0-beta` line, so the override is now a plain version pin against
the auto-published betas built from `xtermjs/xterm.js@master`:

```json
"@xterm/xterm": "github:juspay/xterm.js#fix/kolu-xterm-fixes-built"
"@xterm/xterm": "6.1.0-beta.225",
"@xterm/addon-webgl": "0.20.0-beta.224"
```

When upstream merges, the override collapses to a plain version bump.

## What I'd tell past-me

Three things to internalise if you came here from a backend or
Expand Down