Add properties tests#926
Open
codefromlani wants to merge 3 commits into
Open
Conversation
jdesrosiers
requested changes
Jun 17, 2026
jdesrosiers
left a comment
jdesrosiers
left a comment
Member
There was a problem hiding this comment.
Please make the general updates we talked about for the default tests.
- Use the object schema
- Include
$schema - Remove the files the original tests
jdesrosiers
requested changes
Jun 19, 2026
jdesrosiers
left a comment
jdesrosiers
left a comment
Member
There was a problem hiding this comment.
tests/v1/properties.json needs to be merged and removed as well.
Comment on lines
+47
to
+48
| "description": | ||
| "properties, patternProperties, additionalProperties interaction", |
Member
There was a problem hiding this comment.
Suggested change
| "description": | |
| "properties, patternProperties, additionalProperties interaction", | |
| "description": "properties, patternProperties, additionalProperties interaction", |
| }, | ||
| { | ||
| "description": "properties with escaped characters", | ||
| "compatibility": "4", |
Member
There was a problem hiding this comment.
This is compatible with all dialects
Suggested change
| "compatibility": "4", |
| }, | ||
| { | ||
| "description": "properties whose names are Javascript object property names", | ||
| "compatibility": "4", |
Member
There was a problem hiding this comment.
This is compatible with all versions.
Suggested change
| "compatibility": "4", |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.