Add maximum tests#922
Conversation
jdesrosiers
left a comment
jdesrosiers
left a comment
There was a problem hiding this comment.
It looks like the draft-03 and draft-04 tests include exclusiveMaximum tests in maximum.json. Starting in draft-06, it splits them into maximum.json and exclusiveMaximum.json.
We should make this consistent. With the unified format, I think it will make most sense to merge exclusvieMaximum.json into maximum.json. Let's do that.
| @@ -0,0 +1,105 @@ | |||
| { | |||
| "$schema": "../validation-test-schema.json", | |||
| "description": "maximumvalidation", | |||
There was a problem hiding this comment.
Let's take care to make human readable descriptions. It doesn't have to be detailed. At a minimum, this should have space between "maximum" and "validation".
| }, | ||
| { | ||
| "description": "maximum validation (explicit false exclusivity)", | ||
| "compatibility": "=4", |
There was a problem hiding this comment.
| "compatibility": "=4", | |
| "compatibility": "3,<=4", |
| }, | ||
| { | ||
| "description": "exclusiveMaximum validation", | ||
| "compatibility": "=4", |
There was a problem hiding this comment.
| "compatibility": "=4", | |
| "compatibility": "3,<=4", |
Done, I updated one of the descriptions. |
jdesrosiers
left a comment
jdesrosiers
left a comment
There was a problem hiding this comment.
Looks good, but make sure you're merging and removing the v1 tests as well.
2 participants
No description provided.