[ftp] Add get_modified_time#1559
Open
staceybeard wants to merge 4 commits into
Open
Conversation
|
@jschneier Any chance this can be considered to be included? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implemented
get_modified_timein theFTPStorageclass, from theStorageinterface (viaBaseStorage).This function returns a file's last updated timestamp as a
datetimevalue.What's Included
storages/backends/ftp.py—get_modified_timefunction with helper function_get_file_last_modified_details(modeled on_get_dir_details). This function uses MLST to get last modified data for a given file.tests/test_ftp.py— Unit tests for success and error cases in the new function.Notes
scjodyintests/test_gcloud.py.