Feat: add suport for azure url override#1539
Open
Gornoka wants to merge 3 commits into
Open
Conversation
Gornoka
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change allows the Azure backend to work with completely custom Blob Storage URLs.
The default implementation assumed that everyone sticks to Azures naming conventions, unfortunately not everyone does. This PR just extends the existing client_options parameter to prevent double passing the
account_url, if it is specified as client_parameter.While testing this I have found that the current implementation changes the
client_paramswithout creating a copy first, if you are interested in changes that address that let me know (would also make the implementation of these changes a little nicer). https://github.com/Gornoka/django-storages/tree/debug/quick/reduce_side_effectsThis might also be a solution to this issue: #1503