Nanobind python bindings + jrl-cmakemodulesv2 + nix - #143
Open
arntanguy wants to merge 17 commits into
Open
Conversation
todo: cleanup, ensure that static build still works
This reverts commit 214fbe2.
arntanguy
force-pushed
the
nix-nanobind
branch
2 times, most recently
from
May 8, 2026 11:16
00783ae to
d937692
Compare
- add_subdirectory(binding/nanobind) was nested inside if(NANOBIND_DOCUMENTATION) instead of if(NANOBIND_BINDINGS), so the nanobind module was never built unless documentation was also enabled. - The leftover find_package(tinyxml2 QUIET NO_MODULE) pre-check (dead code from before the jrl-cmakemodules v2 migration) ran before jrl_find_package(tinyxml2 CONFIG REQUIRED), causing the latter to see tinyxml2::tinyxml2 already imported and skip its own target-tracking. This meant RBDynParsers' generated dependencies.cmake never contained find_dependency(tinyxml2), breaking consumers (e.g. mc_rtc) that link against RBDyn::Parsers. Author: ThomasDuvinage <t.duvinage@outlook.fr>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Superseeds #138
See also jrl-umi3218/SpaceVecAlg#74