Add report regression coverage - #3
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Adds CLI-level regression tests that validate the JSON output from review-pack and policy-pack can be parsed and that key schema fields/arrays are present, using existing fixtures to lock in expected report structure.
Changes:
- Added JSON-parse regression tests for
review-packoutput and required fields/arrays. - Added JSON-parse regression tests for
policy-packoutput and required fields/arrays. - Introduced
serde_json::Valueusage in CLI tests to validate report structure beyond substring matching.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+143
to
+160
| let output = cmd | ||
| .args([ | ||
| "review-pack", | ||
| "--input", | ||
| "tests/fixtures/review-packs/complete", | ||
| "--format", | ||
| "json", | ||
| ]) | ||
| .output() | ||
| .unwrap(); | ||
|
|
||
| assert!(output.status.success()); | ||
| let report: Value = serde_json::from_slice(&output.stdout).unwrap(); | ||
|
|
||
| assert_eq!(report["schema_version"], "0.4"); | ||
| assert!(report["artifacts_detected"].as_array().unwrap().len() >= 4); | ||
| assert!(!report["review_questions"].as_array().unwrap().is_empty()); | ||
| } |
Comment on lines
+210
to
+228
| let output = cmd | ||
| .args([ | ||
| "policy-pack", | ||
| "--input", | ||
| "tests/fixtures/policy-packs/multisig-timelock", | ||
| "--format", | ||
| "json", | ||
| ]) | ||
| .output() | ||
| .unwrap(); | ||
|
|
||
| assert!(output.status.success()); | ||
| let report: Value = serde_json::from_slice(&output.stdout).unwrap(); | ||
|
|
||
| assert_eq!(report["schema_version"], "0.5"); | ||
| assert_eq!(report["pack_type"], "policy_pack"); | ||
| assert!(!report["evidence_documents"].as_array().unwrap().is_empty()); | ||
| assert!(!report["missing_evidence"].as_array().unwrap().is_empty()); | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation