[codex] implement review-pack v0.4 - #1
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Implements the review-pack v0.4 feature, adding a new CLI subcommand that analyzes a local directory of Bitcoin review artifacts (descriptor, PSBT, transaction, script, policy, notes) and emits a consolidated JSON/Markdown report with cross-artifact checks.
Changes:
- Added
review-packanalysis pipeline and v0.4ReviewPackReportschema/reporting. - Added Markdown/JSON rendering and CLI wiring for
btc-risk-lab review-pack ... [--output FILE]. - Added fixture review-pack directory plus CLI regression tests, and updated docs + crate version to v0.4.0.
Reviewed changes
Copilot reviewed 15 out of 16 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/fixtures/review-packs/complete/tx.json | Adds a transaction fixture for complete review-pack coverage. |
| tests/fixtures/review-packs/complete/script.txt | Adds a script fixture (CSV-related opcode) for review-pack coverage. |
| tests/fixtures/review-packs/complete/psbt.base64 | Adds a PSBT fixture for review-pack coverage. |
| tests/fixtures/review-packs/complete/policy.json | Adds a policy JSON fixture to be surfaced in the report. |
| tests/fixtures/review-packs/complete/notes.md | Adds notes fixture content for review-pack coverage. |
| tests/fixtures/review-packs/complete/descriptor.txt | Adds a descriptor fixture for review-pack coverage. |
| tests/cli.rs | Adds CLI regression tests for review-pack JSON stdout and Markdown file output. |
| src/review_pack.rs | Introduces the review-pack analyzer, schema structs, and cross-artifact checks. |
| src/report/mod.rs | Adds rendering for ReviewPackReport in JSON and Markdown. |
| src/main.rs | Adds review-pack subcommand and output-to-file support. |
| src/lib.rs | Exposes the new review_pack module publicly. |
| ROADMAP.md | Marks review-pack capability as completed and clarifies non-goals. |
| README.md | Documents the new command, artifact inputs, and limitations. |
| CHANGELOG.md | Adds v0.4.0 release notes for review-pack. |
| Cargo.toml | Bumps crate version to 0.4.0. |
| Cargo.lock | Updates lockfile version entry for 0.4.0. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements v0.4
review-pack, a consolidated local report for Bitcoin review packages containing descriptor, PSBT, transaction, script, policy, and notes artifacts.What changed
btc-risk-lab review-pack --input DIR --format json|markdown [--output FILE].0.4ReviewPackReportwith detected artifacts, per-artifact summaries, consolidated risk, warnings, missing data, cross-artifact findings, review questions, and limitations.tests/fixtures/review-packs/and CLI coverage for JSON and Markdown output.Security boundaries
review-packperforms local file analysis only. It does not sign, create wallets, handle keys, broadcast transactions, or make network calls.Validation
cargo fmtcargo clippy --all-targets --all-features -- -D warningscargo test --all-featurescargo run --quiet -- review-pack --input tests/fixtures/review-packs/complete --format markdownKnown limitations
Cross-artifact checks compare available heuristic signals and input/output counts. The report explicitly does not prove descriptor-to-PSBT equivalence, transaction extraction from a PSBT, exact threshold/signer-set ownership, wallet state, or consensus/policy validity.