[7.0] Remove usage of LegacyPropertyManagementTrait from Table class#44909
Open
Hackwar wants to merge 19 commits into
Open
[7.0] Remove usage of LegacyPropertyManagementTrait from Table class#44909Hackwar wants to merge 19 commits into
Hackwar wants to merge 19 commits into
Conversation
Member
|
@Hackwar code review is not enough, you please write test instruction, in this case test all touched table/model classes from code review it's ok |
Hackwar
changed the title
Hackwar
changed the title
10 tasks
laoneo
reviewed
May 19, 2026
| ]; | ||
|
|
||
| $this->object->set('_jsonEncode', ['params']); | ||
| $reflection = new \ReflectionClass($this->object); |
Member
Author
There was a problem hiding this comment.
Feel free to fundamentally change the test, but if you want to set the internal parameters, you have to do something different than to use the LegacyPropertyManagementTrait. 😉
Contributor
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
This PR was first aimed at removing the
LegacyPropertyManagementTraitentirely, but it is so widely used, that it is not realistic to do so for 6.0. So now this only removes the usage of the trait for the Table class in the core. The code from the trait has been deprecated since Joomla 3.4.0, even though it has been moved around and with Joomla 4.0 has finally ended up in the legacy trait. From my perspective, it is time to do this after 11 years of it being deprecated: https://github.com/joomla/joomla-cms/blob/3.4.0/libraries/joomla/object/object.phpThe trait should be removed with Joomla 8.0 definitely.
Testing Instructions
Codereview.
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org: Removal of LegacyPropertyManagementTrait and CMSObject Manual#615
No documentation changes for manual.joomla.org needed